fix(Overlay): overlay support SSR, close #4205 #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FairyYang
force-pushed
the
fix-issue-4205
branch
from
8f6c856
to
5d65ef6
Compare
eternalsky
requested changes
Sep 4, 2024
FairyYang
force-pushed
the
fix-issue-4205
branch
from
5d65ef6
to
f70ca80
Compare
eternalsky
requested changes
Sep 5, 2024
components/overlay/popup.tsx
Outdated
| @@ -111,7 +111,9 @@ class Popup extends Component<PopupProps, PopupState> { | |||
| delay: 200, | |||
| canCloseByTrigger: true, | |||
| followTrigger: false, | |||
| container: () => document.body, | |||
| container: () => { | |||
| if (typeof document !== 'undefined') return document.body; | |||
There was a problem hiding this comment.
我理解是要的，因为在服务器端渲染（SSR）的过程中，React 组件的静态属性（如 static defaultProps）会在服务器端执行。
There was a problem hiding this comment.
执行的是函数声明，而不是函数本身的执行，函数本身不执行就没有问题。
FairyYang
force-pushed
the
fix-issue-4205
branch
from
f70ca80
to
3750dc9
Compare
eternalsky
requested changes
Sep 5, 2024
components/overlay/overlay.tsx
Outdated
| ) { | ||
| return; | ||
| } | ||
| if ( |
There was a problem hiding this comment.
这里去掉 document 了之后好像就没有拆成两个 if 的意义了
components/overlay/overlay.tsx
Outdated
| @@ -622,7 +626,7 @@ class Overlay extends Component<OverlayV1Props, OverlayState> { | |||
| const path = [] as Array<HTMLElement | Document | Window>; | |||
| while (el) { | |||
| path.push(el); | |||
| if (el.tagName === 'HTML') { | |||
| if (el.tagName === 'HTML' && typeof document !== 'undefined') { | |||
FairyYang
force-pushed
the
fix-issue-4205
branch
from
3750dc9
to
d360cd4
Compare
eternalsky
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.